Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jt/notifications config UI and models #35310

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Jt/notifications config UI and models #35310

wants to merge 4 commits into from

Conversation

Jtang-1
Copy link
Contributor

@Jtang-1 Jtang-1 commented Oct 31, 2024

Product Description

Technical Summary

Feature Flag

Safety Assurance

Safety story

Automated test coverage

QA Plan

Migrations

  • The migrations in this code can be safely applied first independently of the code

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@dimagimon dimagimon added the reindex/migration Reindex or migration will be required during or before deploy label Oct 31, 2024
@sentry-io Sentry.io
Copy link

sentry-io bot commented Oct 31, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: corehq/messaging/scheduling/forms.py

Function Unhandled Issue
add_additional_content_types AttributeError: 'BroadcastForm' object has no attribute 'CONNECT_MESSAGE_CONTENT' /a/{...
Event Count: 2
add_additional_content_types AttributeError: 'ConditionalAlertScheduleForm' object has no attribute 'CONNECT_MESSAGE_CONTENT' ...
Event Count: 1
get_layout_fields TypeError: not all arguments converted during string formatting /a/{domain}/messaging/...
Event Count: 1
distill_content TypeError: ConnectMessageContent() got unexpected keyword arguments: 'message' /a/{dom...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orangejenny orangejenny Awaiting requested review from orangejenny orangejenny will be requested when the pull request is marked ready for review orangejenny is a code owner

@mkangia mkangia Awaiting requested review from mkangia mkangia will be requested when the pull request is marked ready for review mkangia is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
reindex/migration Reindex or migration will be required during or before deploy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jtang-1 @dimagimon